Remove void return types from test methods and fix code style

- Remove void return types from TextTrimTransformerTest methods
- Apply PHP-CS-Fixer to ensure consistent code style across store component

Author: OskarStark

src/store/src/Document/Loader/TextFileLoader.php

@@ -28,7 +28,7 @@ public function load(?string $source, array $options = []): iterable
         if (null === $source) {
             throw new InvalidArgumentException('TextFileLoader requires a file path as source, null given.');
         }
-        
+
         if (!is_file($source)) {
             throw new RuntimeException(\sprintf('File "%s" does not exist.', $source));
         }

src/store/src/Document/Transformer/TextSplitTransformer.php

@@ -34,7 +34,7 @@ public function __construct(
         private int $overlap = 200,
     ) {
         if ($this->overlap < 0 || $this->overlap >= $this->chunkSize) {
-            throw new InvalidArgumentException(sprintf('Overlap must be non-negative and less than chunk size. Got chunk size: %d, overlap: %d.', $this->chunkSize, $this->overlap));
+            throw new InvalidArgumentException(\sprintf('Overlap must be non-negative and less than chunk size. Got chunk size: %d, overlap: %d.', $this->chunkSize, $this->overlap));
         }
     }
 

src/store/src/Indexer.php

@@ -25,29 +25,29 @@
 final readonly class Indexer implements IndexerInterface
 {
     /**
-     * @param null|string|array<string> $source
-     * @param TransformerInterface[] $transformers
+     * @param string|array<string>|null $source
+     * @param TransformerInterface[]    $transformers
      */
     public function __construct(
         private LoaderInterface $loader,
         private VectorizerInterface $vectorizer,
         private StoreInterface $store,
-        private null|string|array $source = null,
+        private string|array|null $source = null,
         private array $transformers = [],
         private LoggerInterface $logger = new NullLogger(),
     ) {
     }
 
-    public function index(null|string|array $source = null, array $options = []): void
+    public function index(string|array|null $source = null, array $options = []): void
     {
         // Prevent conflicting sources
         if (null !== $source && null !== $this->source) {
             throw new \LogicException('Cannot provide a source when indexer already has a configured source. Use a different indexer instance or call index() without arguments.');
         }
-        
+
         // Use configured source if no source is provided
         $source = $source ?? $this->source;
-        
+
         $this->logger->debug('Starting document processing', ['source' => $source, 'options' => $options]);
 
         $sources = null === $source ? [null] : (array) $source;
@@ -58,7 +58,7 @@ public function index(null|string|array $source = null, array $options = []): vo
 
         if ([] === $documents) {
             $this->logger->debug('No documents to process', ['source' => $source]);
-            
+
             return;
         }
 
@@ -91,7 +91,7 @@ public function index(null|string|array $source = null, array $options = []): vo
     /**
      * @return TextDocument[]
      */
-    private function loadSource(null|string $source): array
+    private function loadSource(?string $source): array
     {
         $documents = [];
 

src/store/src/IndexerInterface.php

@@ -20,9 +20,9 @@ interface IndexerInterface
 {
     /**
      * Process sources through the complete document pipeline: load → transform → vectorize → store.
-     * 
-     * @param null|string|array<string> $source  Source identifier (file path, URL, etc.), array of sources, or null if the loader does not need a source, e.g. InMemoryLoader
-     * @param array{chunk_size?: int} $options Processing options
+     *
+     * @param string|array<string>|null $source  Source identifier (file path, URL, etc.), array of sources, or null if the loader does not need a source, e.g. InMemoryLoader
+     * @param array{chunk_size?: int}   $options Processing options
      */
-    public function index(null|string|array $source = null, array $options = []): void;
+    public function index(string|array|null $source = null, array $options = []): void;
 }

src/store/tests/Document/Loader/InMemoryLoaderTest.php

@@ -64,7 +64,7 @@ public function testLoadIgnoresSourceParameter()
     {
         $document = new TextDocument(Uuid::v4(), 'Test content');
         $loader = new InMemoryLoader([$document]);
-        
+
         // Source parameter should be ignored - same result regardless of value
         $documentsWithNull = iterator_to_array($loader->load(null));
         $documentsWithString = iterator_to_array($loader->load('ignored-source'));

src/store/tests/Document/Transformer/TextTrimTransformerTest.php

@@ -12,7 +12,6 @@
 namespace Symfony\AI\Store\Tests\Document\Transformer;
 
 use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\TestWith;
 use PHPUnit\Framework\TestCase;
 use Symfony\AI\Store\Document\Metadata;
@@ -34,7 +33,7 @@ final class TextTrimTransformerTest extends TestCase
     #[TestWith(['already trimmed', 'already trimmed'])]
     #[TestWith([' mixed   whitespace ', 'mixed   whitespace'])]
     #[TestWith(["\r\ncarriage return and newline\r\n", 'carriage return and newline'])]
-    public function testTrim(string $input, string $expected): void
+    public function testTrim(string $input, string $expected)
     {
         $transformer = new TextTrimTransformer();
         $document = new TextDocument(Uuid::v4(), $input);
@@ -45,17 +44,17 @@ public function testTrim(string $input, string $expected): void
         $this->assertSame($expected, $result[0]->content);
     }
 
-    public function testTrimHandlesOnlyWhitespace(): void
+    public function testTrimHandlesOnlyWhitespace()
     {
         // Note: TextDocument doesn't allow empty content, so we can't test trimming to empty string
         // This test verifies that attempting to create a document with only whitespace throws an exception
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessage('The content shall not be an empty string.');
-        
+
         new TextDocument(Uuid::v4(), '   ');
     }
 
-    public function testTrimProcessesMultipleDocuments(): void
+    public function testTrimProcessesMultipleDocuments()
     {
         $transformer = new TextTrimTransformer();
         $documents = [
@@ -72,7 +71,7 @@ public function testTrimProcessesMultipleDocuments(): void
         $this->assertSame('third', $result[2]->content);
     }
 
-    public function testTrimPreservesMetadata(): void
+    public function testTrimPreservesMetadata()
     {
         $transformer = new TextTrimTransformer();
         $metadata = new Metadata(['key' => 'value']);
@@ -85,7 +84,7 @@ public function testTrimPreservesMetadata(): void
         $this->assertSame($metadata, $result[0]->metadata);
     }
 
-    public function testTrimPreservesDocumentId(): void
+    public function testTrimPreservesDocumentId()
     {
         $transformer = new TextTrimTransformer();
         $id = Uuid::v4();

src/store/tests/IndexerTest.php

@@ -15,7 +15,6 @@
 use PHPUnit\Framework\Attributes\Medium;
 use PHPUnit\Framework\Attributes\UsesClass;
 use PHPUnit\Framework\TestCase;
-use Psr\Log\LoggerInterface;
 use Symfony\AI\Platform\Bridge\OpenAi\Embeddings;
 use Symfony\AI\Platform\Message\ToolCallMessage;
 use Symfony\AI\Platform\Platform;