refactor(store): embeddings limit removed

Author: Guikingone

examples/compose.yaml

@@ -33,5 +33,7 @@ services:
   surrealdb:
       image: surrealdb/surrealdb:v2
       command: ['start', '--user', 'symfony', '--pass', 'symfony']
+      environment:
+          SURREAL_HTTP_MAX_KEY_BODY_SIZE: 49152
       ports:
           - '8000:8000'

src/store/CHANGELOG.md

@@ -43,6 +43,7 @@ CHANGELOG
    - ChromaDB
    - Pinecone
    - Qdrant
+   - SurrealDB
  * Add Retrieval Augmented Generation (RAG) support:
    - Document embedding storage
    - Similarity search for relevant documents

src/store/src/Bridge/SurrealDB/Store.php

@@ -27,8 +27,6 @@
  */
 final class Store implements InitializableStoreInterface, VectorStoreInterface
 {
-    private const MAXIMUM_EMBEDDINGS_DIMENSIONS = 1275;
-
     public function __construct(
         private readonly HttpClientInterface $httpClient,
         private readonly string $endpointUrl,
@@ -43,7 +41,7 @@ public function __construct(
         private readonly string $table = 'vectors',
         private readonly string $vectorFieldName = '_vectors',
         private readonly string $strategy = 'cosine',
-        private readonly int $embeddingsDimension = self::MAXIMUM_EMBEDDINGS_DIMENSIONS,
+        private readonly int $embeddingsDimension = 1536,
     ) {
     }
 
@@ -52,10 +50,6 @@ public function add(VectorDocument ...$documents): void
         $authenticationToken = $this->authenticate([]);
 
         foreach ($documents as $document) {
-            if (self::MAXIMUM_EMBEDDINGS_DIMENSIONS < $document->vector->getDimensions()) {
-                throw new InvalidArgumentException(\sprintf('The SurrealDB HTTP API does not support embeddings with more than %d dimensions, found %d', self::MAXIMUM_EMBEDDINGS_DIMENSIONS, $document->vector->getDimensions()));
-            }
-
             $this->request('POST', \sprintf('key/%s', $this->table), $this->convertToIndexableArray($document), [
                 'Surreal-NS' => $this->namespace,
                 'Surreal-DB' => $this->database,
@@ -66,10 +60,6 @@ public function add(VectorDocument ...$documents): void
 
     public function query(Vector $vector, array $options = [], ?float $minScore = null): array
     {
-        if (self::MAXIMUM_EMBEDDINGS_DIMENSIONS < $vector->getDimensions()) {
-            throw new InvalidArgumentException(\sprintf('The dimensions of the vector must be less than or equal to %d, found %d', self::MAXIMUM_EMBEDDINGS_DIMENSIONS, $vector->getDimensions()));
-        }
-
         $authenticationToken = $this->authenticate($options);
 
         $vectors = json_encode($vector->getData());
@@ -160,9 +150,7 @@ private function convertToVectorDocument(array $data): VectorDocument
         return new VectorDocument(
             id: Uuid::fromString($id),
             vector: $vector,
-            metadata: new Metadata(array_merge($data['_metadata'], [
-                $this->vectorFieldName => $data[$this->vectorFieldName],
-            ])),
+            metadata: new Metadata($data['_metadata']),
         );
     }
 

src/store/tests/Bridge/SurrealDB/StoreTest.php

@@ -16,7 +16,6 @@
 use Symfony\AI\Platform\Vector\Vector;
 use Symfony\AI\Store\Bridge\SurrealDB\Store;
 use Symfony\AI\Store\Document\VectorDocument;
-use Symfony\AI\Store\Exception\InvalidArgumentException;
 use Symfony\Component\HttpClient\Exception\ClientException;
 use Symfony\Component\HttpClient\MockHttpClient;
 use Symfony\Component\HttpClient\Response\JsonMockResponse;
@@ -115,26 +114,6 @@ public function testStoreCannotAddOnInvalidResponse(): void
         $store->add(new VectorDocument(Uuid::v4(), new Vector([0.1, 0.2, 0.3])));
     }
 
-    public function testStoreCannotAddOnOversizedEmbeddings(): void
-    {
-        $httpClient = new MockHttpClient([
-            new JsonMockResponse([
-                'code' => 200,
-                'details' => 'Authentication succeeded.',
-                'token' => 'bar',
-            ], [
-                'http_code' => 200,
-            ]),
-        ], 'http://localhost:8000');
-
-        $store = new Store($httpClient, 'http://localhost:8000', 'test', 'test', 'test', 'test');
-
-        self::expectException(InvalidArgumentException::class);
-        self::expectExceptionMessage('The SurrealDB HTTP API does not support embeddings with more than 1275 dimensions, found 2000');
-        self::expectExceptionCode(0);
-        $store->add(new VectorDocument(Uuid::v4(), new Vector(array_fill(0, 2000, 0.1))));
-    }
-
     public function testStoreCannotAddOnInvalidAddResponse(): void
     {
         $httpClient = new MockHttpClient([
@@ -257,55 +236,6 @@ public function testStoreCannotQueryOnInvalidResponse(): void
         $store->query(new Vector(array_fill(0, 1275, 0.1)));
     }
 
-    public function testStoreCannotQueryOnOversizedEmbeddings(): void
-    {
-        $httpClient = new MockHttpClient([
-            new JsonMockResponse([
-                'code' => 200,
-                'details' => 'Authentication succeeded.',
-                'token' => 'bar',
-            ], [
-                'http_code' => 200,
-            ]),
-            new JsonMockResponse([
-                [
-                    'result' => [
-                        [
-                            'id' => Uuid::v4()->toRfc4122(),
-                            '_vectors' => [0.1, 0.1, 0.1],
-                            '_metadata' => [
-                                '_id' => Uuid::v4()->toRfc4122(),
-                            ],
-                        ],
-                        [
-                            'id' => Uuid::v4()->toRfc4122(),
-                            '_vectors' => [0.1, 0.1, 0.1],
-                            '_metadata' => [
-                                '_id' => Uuid::v4()->toRfc4122(),
-                            ],
-                        ],
-                    ],
-                    'status' => 'OK',
-                    'time' => '263.208µs',
-                ],
-            ], [
-                'http_code' => 200,
-            ]),
-            new JsonMockResponse([], [
-                'http_code' => 400,
-            ]),
-        ], 'http://localhost:8000');
-
-        $store = new Store($httpClient, 'http://localhost:8000', 'test', 'test', 'test', 'test', 'test');
-
-        $store->add(new VectorDocument(Uuid::v4(), new Vector(array_fill(0, 1275, 0.1))));
-
-        self::expectException(InvalidArgumentException::class);
-        self::expectExceptionMessage('The dimensions of the vector must be less than or equal to 1275, found 2000');
-        self::expectExceptionCode(0);
-        $store->query(new Vector(array_fill(0, 2000, 0.1)));
-    }
-
     public function testStoreCanQueryOnValidEmbeddings(): void
     {
         $httpClient = new MockHttpClient([