Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing a Transaction Offline Guide #432

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

matthewkim93
Copy link
Contributor

  • 2 screeshots
  • 1 example code (typescript)

- Both your offline and online :doc:`workstations <../../getting-started/setup-workstation.rst>` are set up for Symbol-CLI and Symbol-SDK.
- You installed the `Symbol URI scheme <https://github.com/nemfoundation/symbol-uri-scheme>`_.

***************************************************
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to show in a previous step how to create an offline account with the CLI.
You will have to pass to symbol-cli account generate the options --network, --generation-hash, --namespace-id, and divisibility. Pass the option --help to know more about each parameter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I included an optional step 0 (we can redo the numbering to if you think that's better. I showed how to generate an account. I'm not sure how you would save the account and create a transaction from the account with the cli without connecting to the internet though.

I wasn't too sure what you meant by "the options --network, --generation-hash, --namespace-id, and divisibility. Pass the option --help to know more about each parameter."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the guide to start at 1.

I'm not sure how you would save the account and create a transaction from the account with the cli without connecting to the internet though.

When creating a profile, the CLI retrieves some information automatically from the node connected. In order to create an account without having internet connection, the user needs to pass the following options manually: --generation-hash, --namespace-id, and --divisibility.

I attach in this image how I managed to create an account without internet:

image

@dgarcia360
Copy link
Collaborator

dgarcia360 commented Jul 1, 2020

Looks good to me, we will improve the process before merging to not have to open the SDK to construct the URI.
Also, would prefer to show text instead of screenshots for the CLI.

@dgarcia360 dgarcia360 changed the base branch from master to main July 22, 2020 10:14
@segfaultxavi segfaultxavi linked an issue Sep 16, 2020 that may be closed by this pull request
@segfaultxavi
Copy link
Collaborator

Some notes to myself:

  • It would be nice if the process could be done completely using only CLI (See Add URI conversion facilities symbol-cli#328)
  • TS and CLI code should be shown together using example code blocks as done in the Delegated Harvesting guide Delegated harvesting #531.
  • "Create an offline account" should be a prerequisite and explain where to get all that info.
  • Obviously no screenshots, only text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Guide] Sign transactions offline
3 participants