Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "Main contributor" besides "Last contributor" on every page #746

Open
2 tasks
segfaultxavi opened this issue Dec 29, 2021 · 0 comments · May be fixed by #748
Open
2 tasks

Show "Main contributor" besides "Last contributor" on every page #746

segfaultxavi opened this issue Dec 29, 2021 · 0 comments · May be fixed by #748
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@segfaultxavi
Copy link
Collaborator

segfaultxavi commented Dec 29, 2021

It does not feel right to only show the last contributor when sometimes 99% of the commits are from a different person.

Below the "Last updated by" line in the footer we can add something like "Main contributor XYZ with X commits.", also with picture and GitHub link, which shows the author with most commits.

This would need:

  • Changing source/_ext/gitstamp.py to retrieve this info from git shortlog -sn and put it in the context variable.
    • Use the git Python package as it is already done, obviously, no more calling external processes and piping output.
    • Rename gitauthor, gitavatar and gitlogin to gitLastAuthor, gitLastAvatar and gitLastLogin.
    • Call the new variables gitMainAuthor, gitMainAvatar and gitMainLogin.
  • Changing source/_templates/include/footer.html to render this info.
    • Be careful with the two layouts (desktop and mobile).
@segfaultxavi segfaultxavi added the enhancement New feature or request label Dec 29, 2021
@segfaultxavi segfaultxavi added the good first issue Good for newcomers label Dec 29, 2021
@mjh316 mjh316 linked a pull request Dec 31, 2021 that will close this issue
@segfaultxavi segfaultxavi linked a pull request Dec 31, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant