Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advancedworkflow.js breaks if Workflow actions are not on page in CMS #416

Open
wakes opened this issue Feb 3, 2020 · 1 comment
Open

Comments

@wakes
Copy link

wakes commented Feb 3, 2020

Hi. If the workflow actions are not rendered into the CMS (e.g. WorkflowApplicable extension fails permission check line ~186) then the advancedworkflow.js script fails trying to process a click event because fields it is trying to do a replace on non-existant attribute 'name' value , see advanced-workflow-cms.js:~12. Should be some defensive coding in there to check that the field/attribute exists.

This is an issue in CWP as we can't seem to disable the AdvancedWorkflows module as part of the recipe.

Cheers,
Steve

@emteknetnz
Copy link
Collaborator

Hi Steve, thanks for reporting

Would you be keen to submit a PR to fix this issue, or at least some code that you think would fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants