Find a better place to invoke setIsWorkflowInEffect than inside updateCMSFields

[olyism]

$this->setIsWorkflowInEffect() is invoked in updateCMSFields within WorkflowEmbargoExpiryExtension.php.

It may be better to refactor and invoke this somewhere else, e.g. within onBeforeWrite.

[nyeholt]

isWorkflowInEffect is not actually persisted to the database though, it's only used for things like determining which fields should be shown at a particular point in time.