Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponsorblock support #171

Open
kaoru2 opened this issue May 20, 2024 · 4 comments
Open

Sponsorblock support #171

kaoru2 opened this issue May 20, 2024 · 4 comments

Comments

@kaoru2
Copy link

kaoru2 commented May 20, 2024

Heya! Sponsorblock may be a nice addition esp when downloading music/videos with sponsorships and such.

@x-R0b0T-x
Copy link

I agree, Sponsorblock support is missing and that would be perfect!

@sylviiu
Copy link
Owner

sylviiu commented Aug 21, 2024

i... personally don't like the idea; i feel like segments could cut into content that's not in its sponsorblock category

however, seeing that this issue gained any sort of traction (not used to actually seeing more than a single person here haha!) i can look into adding support :D

@sylviiu
Copy link
Owner

sylviiu commented Aug 21, 2024

wrote the above reply in the thought that you're requesting the video to be automatically cut up to exclude those sponsorblock segments - is this what you'd be asking for? or would you be asking for some sort of metadata embedding into the video as well? personally not sure how i'd go about the latter

@kaoru2
Copy link
Author

kaoru2 commented Oct 1, 2024

wrote the above reply in the thought that you're requesting the video to be automatically cut up to exclude those sponsorblock segments - is this what you'd be asking for?

I feel like letting the user toggle a switch, and select any segment to include(including the default) will do. Doing the cuts automatically will cause problems down the road. I also think that having a section in preferences to toggle which types of segments to skip by default will also be great.

or would you be asking for some sort of metadata embedding into the video as well? personally not sure how i'd go about the latter

Metadata embedding is a plus, but for the general users, I think that implementing it is unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants