added a ExifTool bytes read/write test

Author: sylikc

tests/common_util.py

@@ -8,6 +8,7 @@
 
 from pathlib import Path
 import tempfile
+import os
 
 from typing import Optional, Tuple, Any
 
@@ -21,7 +22,7 @@
 SCRIPT_PATH = Path(__file__).resolve().parent
 
 # location to images directory
-TEST_IMAGE_DIR = SCRIPT_PATH / "images"
+TEST_IMAGE_DIR = SCRIPT_PATH / "files"
 
 
 # Find example image (note: JPG is listed explicitly, as it may have different tags than other file types)
@@ -67,3 +68,25 @@ def et_get_temp_dir(suffix: Optional[str] = None, base_path: Optional[Path] = No
 
 # ---------------------------------------------------------------------------------------------------------
 
+
+def create_random_bin_file(filepath: Path, size: int):
+	"""
+	generate random binary file with the specified size in bytes
+
+	:param filename: the filename
+	:param size: the size in bytes
+
+	:return: filepath
+	"""
+	# https://www.bswen.com/2018/04/python-How-to-generate-random-large-file-using-python.html
+
+	if filepath.exists():
+		raise FileExistsError
+
+	with open(filepath, 'wb') as f:
+		f.write(os.urandom(size))
+
+	return filepath
+
+# ---------------------------------------------------------------------------------------------------------
+

tests/files/README.txt

@@ -1,4 +1,4 @@
-This folder contains images used in tests.
+This folder contains images/files used in tests.
 
 More may be added at a later time to test different file formats.
 

tests/files/my_makernotes.config

@@ -0,0 +1,14 @@
+# find sample file here -- https://exiftool.org/config.html
+
+# this file was created from a Phil Harvey example here: https://exiftool.org/forum/index.php?topic=5563.msg26986#msg26986
+
+%Image::ExifTool::UserDefined = (
+	'Image::ExifTool::Exif::Main' => {
+		0x927c => {
+			Name => 'MyMakerNotes',
+			Writable => 'undef',
+			Binary => 1,
+		},
+	},
+);
+1; # end

tests/test_exiftool_bytes.py

@@ -0,0 +1,74 @@
+# -*- coding: utf-8 -*-
+"""
+Test :: ExifTool base class - execute() using raw_bytes parameter
+"""
+
+# standard
+import unittest
+import shutil
+
+# test helpers
+from tests.common_util import et_get_temp_dir, TEST_IMAGE_DIR, TEST_IMAGE_JPG, create_random_bin_file
+
+# custom
+import exiftool
+
+class TestExifToolBytes(unittest.TestCase):
+
+	# ---------------------------------------------------------------------------------------------------------
+	def setUp(self):
+		self.et = exiftool.ExifTool(common_args=["-G", "-n", "-overwrite_original"], config_file=TEST_IMAGE_DIR / "my_makernotes.config")
+
+		(self.temp_obj, self.temp_dir) = et_get_temp_dir(suffix="etbytes")
+
+	def tearDown(self):
+		if self.et.running:
+			self.et.terminate()
+
+	# ---------------------------------------------------------------------------------------------------------
+
+	def test_read_write_binary(self):
+		self.assertFalse(self.et.running)
+		self.et.run()
+
+		### set up files ###
+
+		# write a binary file to test with ... we can make it random or the same, shouldn't matter
+		BIN_FILE_SIZE = 1024
+
+		p_bin_file = self.temp_dir / "test_data.bin"
+		create_random_bin_file(p_bin_file, BIN_FILE_SIZE)
+
+		p_jpg_file = self.temp_dir / "rose.jpg"
+		shutil.copyfile(TEST_IMAGE_JPG, p_jpg_file)
+
+		### write the binary data ###
+		self.et.execute(f"-MyMakerNotes<={p_bin_file}", str(p_jpg_file))
+		self.assertEqual(self.et.last_status, 0)
+
+		### read the binary data and compare ###
+		with open(p_bin_file, 'rb') as f:
+			bin_file_data = f.read()
+
+		# make sure it's the right amount of bytes wrote in originally
+		self.assertEqual(len(bin_file_data), BIN_FILE_SIZE)
+
+		# get the custom tag
+		written_bin_data = self.et.execute("-b", "-MyMakerNotes", str(p_jpg_file), raw_bytes=True)
+
+		# check that they are equal
+		self.assertEqual(bin_file_data, written_bin_data)
+
+
+
+
+
+
+
+
+	""" also write tests to allow executehelper to use the execute(raw_bytes) and test whether it works with check error """
+
+	""" test multi tags in mixed encoding with bytes """
+
+	""" drawback to change is that it would be slower as the param list is copied again internally """
+