Skip to content

Disable Go runtime GC for starter process #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2021
Merged

Conversation

dtrudg
Copy link
Member

@dtrudg dtrudg commented May 5, 2021

Description of the Pull Request (PR):

This is an inelegant, but effective work around for #7 that will prevent GC cycle triggered errors until the effects of closing fds in container startup can be further considered for possible re-work.

Allow debug of Go runtime issues in starter

  • Do not clear GOGC and GODEBUG in starter C init
  • Log FD_CLOEXEC on fds

Disable GC for the starter

  • Prevent a GC cycle firing after fds have been closed, which can cause
    a netpoll panic.

Co-authored-by: Adam Hughes tri-adam@users.noreply.github.com

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

 - Do not clear GOGC and GODEBUG in starter C init
 - Log FD_CLOEXEC on fds
@dtrudg dtrudg added the ci:e2e label May 5, 2021
@dtrudg dtrudg added this to the 3.8.0 RC milestone May 5, 2021
@dtrudg dtrudg requested review from EmmEff and tri-adam May 5, 2021 19:48
@dtrudg dtrudg self-assigned this May 5, 2021
@dtrudg dtrudg marked this pull request as draft May 5, 2021 19:48
@dtrudg dtrudg removed request for EmmEff and tri-adam May 5, 2021 19:48
Closes #7

Prevent a GC cycle firing after fds have been closed, which can cause
a netpoll panic.

Co-authored-by: Adam Hughes <tri-adam@users.noreply.github.com>
@dtrudg dtrudg marked this pull request as ready for review May 5, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infrequent GC related netpoll fd error after descriptors closed by starter
2 participants