Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/generalize native-mode code for passing FUSE mounts by file descriptor? #2201

Open
preminger opened this issue Sep 15, 2023 · 1 comment
Assignees
Labels
maybe Features / changes that maybe implemented in future, depending on need & resources techdebt

Comments

@preminger
Copy link
Contributor

Type of issue

Technical debt

Description of issue

Evaluate the prospects for refactoring and/or generalizing the native-mode code that passes FUSE mounts by file descriptor from host to container.

In particular, in the following source files:

  • internal/pkg/runtime/engine/singularity/container_linux.go
  • internal/pkg/runtime/engine/singularity/prepare_linux.go
  • internal/pkg/runtime/engine/singularity/process_linux.go
@dtrudg
Copy link
Member

dtrudg commented Dec 1, 2023

Because we won't be exploring FUSE mount by fd for setuid squashfs/extfs mount, this isn't important at this point.

It may be worth taking up when fuse2fs supports FUSE3, with fd mounts, and setuid FUSE can be revisited.

@dtrudg dtrudg added the maybe Features / changes that maybe implemented in future, depending on need & resources label Dec 1, 2023
@dtrudg dtrudg removed this from the SingularityCE 4.1.0 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maybe Features / changes that maybe implemented in future, depending on need & resources techdebt
Projects
None yet
Development

No branches or pull requests

2 participants