Skip to content

Commit 1e4fd83

Browse files
isheludkopthier
authored andcommitted
Update tests expectations that check stack traces. (nodejs#205)
V8 has changed how Function.blah entries look like in stack traces (see https://crrev.com/c/5907815). This CL updates tests expectations according to new behavior and re-enables the affected tests.
1 parent 1857177 commit 1e4fd83

File tree

5 files changed

+3
-10
lines changed

5 files changed

+3
-10
lines changed

test/message/assert_throws_stack.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
2323
actual: Error: foo
2424
at assert.throws.bar (*assert_throws_stack.js:*)
2525
at getActual (node:assert:*)
26-
at Function.throws (node:assert:*)
26+
at strict.throws (node:assert:*)
2727
at Object.<anonymous> (*assert_throws_stack.js:*:*)
2828
at *
2929
at *

test/message/internal_assert_fail.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Error [ERR_INTERNAL_ASSERTION]: Unreachable!
66
This is caused by either a bug in Node.js or incorrect usage of Node.js internals.
77
Please open an issue with this stack trace at https://github.com/nodejs/node/issues
88

9-
at Function.fail (node:internal/assert:*:*)
9+
at assert.fail (node:internal/assert:*:*)
1010
at * (*test*message*internal_assert_fail.js:7:8)
1111
at *
1212
at *

test/message/message.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@ vm_display_syntax_error.js: SKIP
3333
vm_dont_display_runtime_error.js: SKIP
3434
vm_dont_display_syntax_error.js: SKIP
3535

36-
# Temporarily skip for https://crrev.com/c/5907815
37-
assert_throws_stack.js: SKIP
38-
internal_assert_fail.js: SKIP
39-
4036
[$system==win32]
4137

4238
[$system==linux]

test/parallel/parallel.status

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,6 @@ test-v8-serdes: SKIP
7070

7171
test-v8-stats: SKIP
7272

73-
# Temporarily skip for https://crrev.com/c/5907815
74-
test-fs-promises: SKIP
75-
7673
test-strace-openat-openssl: SKIP
7774
test-policy-dependency-conditions: SKIP
7875

test/parallel/test-fs-promises.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ assert.strictEqual(
5858
code: 'ENOENT',
5959
name: 'Error',
6060
message: /^ENOENT: no such file or directory, access/,
61-
stack: /at async Function\.rejects/
61+
stack: /at async ok\.rejects/
6262
}
6363
).then(common.mustCall());
6464

0 commit comments

Comments
 (0)