Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Improve VPS matching on replace #454

Open
syd711 opened this issue Sep 7, 2024 · 0 comments
Open

[Feature Request] Improve VPS matching on replace #454

syd711 opened this issue Sep 7, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@syd711
Copy link
Owner

syd711 commented Sep 7, 2024

NelsonPJ — Today at 2:30 PM
I updated to 3.5.0 and started updating a few tables. I think I've seen this bug a couple times - when I drag a new VPX into the main window, VPStudio correctly identifies which table it belongs to, and I select the middle option to overwrite the existing table. But then after the table imports and the "Table Data Manager" box pops up, the selected "Virtual Pinball Spreadsheet Entry" is changed to a different version. You can see in the screenshot that I was updating JP's Deadpool (Team Tuga PUP version) to 5.1.2. It was previously 4.0 - and the version number in the main screen correctly updated to 5.1.2, but for some reason the Table Data Manager now shows a completely different spreadsheet version (some version with a VR room that's currently at v1.0).

Syd711 | [MAT] — Today at 2:38 PM
I think the "issue" here is that we apply the automatic VP-spreadsheet matching on table replace. The matching is and never will be a 100% reliable. So it may happen that the matching fails. I have to check if we try to keep it on table-replace which might be the better option - not sure about it.
...I just checked. Yes, we re-match tables on upload and replace. But thinking about it... if the table already has a VPS mapping, it makes sense to change the check so that we only take a closer look on the version and not make a full match again. I'll write a ticket for this.

@syd711 syd711 added the enhancement New feature or request label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants