Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sybrenstuvel/python-rsa
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: version-4.6
Choose a base ref
...
head repository: sybrenstuvel/python-rsa
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: version-4.7
Choose a head ref
  • 17 commits
  • 14 files changed
  • 5 contributors

Commits on Jun 12, 2020

  1. Updated documentation to use Pipenv instead of Poetry

    See commit d15a7f3 for the reason why.
    sybrenstuvel committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    b5e1704 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec57ac0 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2020

  1. Fix exception cause in common.py

    cool-RR authored and sybrenstuvel committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    a87a564 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. Don't build universal wheels

    Wyatt Anderson authored and sybrenstuvel committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    e8fc5d2 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Configuration menu
    Copy the full SHA
    4beb68d View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. Configuration menu
    Copy the full SHA
    da6fc2c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f59ff0 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2020

  1. Fix #165: CVE-2020-25658 - Bleichenbacher-style timing oracle

    Use as many constant-time comparisons as practical in the
    `rsa.pkcs1.decrypt` function.
    
    `cleartext.index(b'\x00', 2)` will still be non-constant-time. The
    alternative would be to iterate over all the data byte by byte in
    Python, which is several orders of magnitude slower. Given that a
    perfect constant-time implementation is very hard or even impossible to
    do in Python [1], I chose the more performant option here.
    
    [1]: https://securitypitfalls.wordpress.com/2018/08/03/constant-time-compare-in-python/
    sybrenstuvel committed Nov 15, 2020
    8 Configuration menu
    Copy the full SHA
    dae8ce0 View commit details
    Browse the repository at this point in the history
  2. Fix #164: Add padding length check as described by PKCS#1 v1.5

    According to PKCS#1 v1.5, the padding should be at least 8 bytes long.
    See https://tools.ietf.org/html/rfc8017#section-7.2.2 step 3 for more info.
    sybrenstuvel committed Nov 15, 2020
    1 Configuration menu
    Copy the full SHA
    f878c37 View commit details
    Browse the repository at this point in the history
  3. Add link to changelog

    sybrenstuvel committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    240b0d8 View commit details
    Browse the repository at this point in the history
  4. Use bytes.find() instead of bytes.index()

    Use `bytes.find()` instead of `bytes.index()`, as the former doesn't raise
    an exception when the to-be-found byte doesn't exist.
    sybrenstuvel committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    f254895 View commit details
    Browse the repository at this point in the history
  5. Directly raise DecryptionError when crypto length is bad

    Crypto length and blocksize are public info, so don't need side-channel
    free comparison.
    sybrenstuvel committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    341e5c4 View commit details
    Browse the repository at this point in the history
  6. Fix #162: Blinding uses slow algorithm

    Store blinding factor + its inverse, so that they can be reused & updated
    on every blinding operation. This avoids expensive computations.
    
    The reuse of the previous blinding factor is done via squaring (mod n), as
    per section 9 of 'A Timing Attack against RSA with the Chinese Remainder
    Theorem' by Werner Schindler, https://tls.mbed.org/public/WSchindler-RSA_Timing_Attack.pdf
    sybrenstuvel committed Nov 15, 2020
    1 Configuration menu
    Copy the full SHA
    06ec1ea View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2021

  1. Configuration menu
    Copy the full SHA
    b81e317 View commit details
    Browse the repository at this point in the history
  2. Fix #170: mistake in examples of documentation

    Strings need to be encoded into bytes before the RSA module can operate
    on them.
    sybrenstuvel committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    539c54a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a364e82 View commit details
    Browse the repository at this point in the history
  4. Bumped version to 4.7

    sybrenstuvel committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    fa3282a View commit details
    Browse the repository at this point in the history
Loading