Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nix): add shell completion and avoid impure #293

Merged
merged 2 commits into from
Oct 22, 2023
Merged

refactor(nix): add shell completion and avoid impure #293

merged 2 commits into from
Oct 22, 2023

Conversation

XYenon
Copy link
Contributor

@XYenon XYenon commented Oct 21, 2023

No description provided.

@XYenon XYenon mentioned this pull request Oct 21, 2023
devenv = {
url = "github:cachix/devenv";
inputs.nixpkgs.follows = "nixpkgs";
rust-overlay = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need the rust overlay because yazi relies on a more recent rust than what is nixpkgs ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-src is needed to make rust-analyzer works, is there any way to get it from nixpkgs?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-analyzer seems to be in nixpkgs but I dont have much experience with the whole process so I trust you :)

Copy link

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot, that worked .

@sxyazi
Copy link
Owner

sxyazi commented Oct 22, 2023

Thanks, let me merge it now!

@sxyazi sxyazi merged commit dbd36b0 into sxyazi:main Oct 22, 2023
3 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants