Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom branches with ya pack #1510

Closed
2 of 3 tasks
uncenter opened this issue Aug 18, 2024 · 2 comments
Closed
2 of 3 tasks

Support custom branches with ya pack #1510

uncenter opened this issue Aug 18, 2024 · 2 comments
Labels
feature New feature request

Comments

@uncenter
Copy link
Contributor

yazi --debug output

N/A

Please describe the problem you're trying to solve

Mentioned in #1471, support for specifying a branch from which to install the plugin. Plugin authors may want to use branches to support upcoming/unreleased or older Yazi versions, or to test out features.

Would you be willing to contribute this feature?

  • Yes, I'll give it a shot

Describe the solution you'd like

ya pack already can track a rev (formerly commit) in package.toml, so it should just be a matter of parsing the branch (rev) from the CLI arg.

Additional context

No response

Validations

  • I have searched the existing issues
  • The latest nightly build of Yazi doesn't already have this feature
@uncenter uncenter added the feature New feature request label Aug 18, 2024
@sxyazi sxyazi mentioned this issue Aug 18, 2024
55 tasks
@sxyazi
Copy link
Owner

sxyazi commented Aug 18, 2024

Added to the feature request list, closing in favor of that.

But note that, as I mentioned in #1471 (comment), it might not end up happening as I still need to think about it more.

@sxyazi sxyazi closed this as completed Aug 18, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature request
Projects
None yet
Development

No branches or pull requests

2 participants