feat(controllers): update backup data for language groups requirement

[rhahao]

No description provided.

[coderabbitai]

Walkthrough

The changes update the logic in two controllers to determine when to include specific fields (publisher_unbaptized, publisher_baptized, and categories) in user backup data. The inclusion of publisher-related fields is now based on the user's publisher role, and the categories field is always included in the returned person data.

Changes

File(s)	Change Summary
src/v3/controllers/pockets_controller.ts, src/v3/controllers/users_controller.ts	Adjusted logic so publisher_unbaptized and publisher_baptized fields are included only if the user is a publisher; always include the categories field in person data; removed redundant variable declarations and updated conditional checks.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Controller
    participant DataStore

    User->>Controller: Request user backup
    Controller->>DataStore: Fetch person data
    DataStore-->>Controller: Return person data
    alt User is publisher
        Controller->>Controller: Include publisher fields in response
    end
    Controller->>Controller: Always include categories field
    Controller-->>User: Return constructed person data

Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn config production Use --omit=dev instead.
npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-05-20T19_45_44_662Z-debug-0.log

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between afd4ab5 and cfc21b3.

📒 Files selected for processing (2)

• src/v3/controllers/pockets_controller.ts (2 hunks)
• src/v3/controllers/users_controller.ts (1 hunks)

🔇 Additional comments (2)

src/v3/controllers/pockets_controller.ts (1)

296-297: Logic update for handling publisher fields and categories

The code now determines whether to include publisher-related fields based on the user's role rather than the person's presence in the miniPersons list. Additionally, the categories field is now always included in the person data output, regardless of user role.

This change aligns with the corresponding update in users_controller.ts, ensuring consistent handling of these fields across both controllers.

Also applies to: 315-317

src/v3/controllers/users_controller.ts (1)

584-586: Matching logic for inclusion of publisher fields and categories

This change mirrors the update in pockets_controller.ts, ensuring consistent behavior across both controllers:

1. The categories field is now always included
2. Publisher-related fields (publisher_unbaptized, publisher_baptized) are now included based on the user's role rather than each person's presence in miniPersons

This creates a more consistent approach to field inclusion based on user roles rather than specific person relationships.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
75.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rhahao]

🎉 This PR is included in version 3.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀