feat: allow relative patterns in configPath

Author: juanrgm

package.json

@@ -115,7 +115,8 @@
         },
         "phpstan.configPath": {
           "type": "string",
-          "description": "PHPStan config path"
+          "description": "PHPStan config path",
+          "default": "{phpstan.neon,phpstan.neon.dist}"
         },
         "phpstan.analysedDelay": {
           "type": "integer",

src/commands/findPHPStanConfigPath.ts

@@ -1,16 +1,15 @@
 import { Ext } from "../extension";
-import { findPHPStanConfigPath as find } from "../utils/phpstan";
-import { isAbsolute, join } from "path";
+import { RelativePattern, workspace } from "vscode";
 
 export default async function findPHPStanConfigPath(ext: Ext) {
   const { settings, cwd } = ext;
-  const configPath = settings.configPath
-    ? isAbsolute(settings.configPath)
-      ? settings.configPath
-      : join(cwd, settings.configPath)
-    : await find(ext.cwd);
-
-  if (!configPath) throw new Error(`Config path not found.`);
+  const [configUri] = await workspace.findFiles(
+    new RelativePattern(cwd, settings.configPath),
+    null,
+    1
+  );
+  if (!configUri) throw new Error(`Config path not found.`);
+  const configPath = configUri.fsPath;
   ext.log({ tag: "configPath", message: configPath });
   return configPath;
 }

src/extension.ts

@@ -199,11 +199,7 @@ export class Ext<
 
     if (this.settings.configFileWatcher)
       this.fileWatchers.register(
-        this.settings.configPath ??
-          new RelativePattern(
-            getWorkspacePath(),
-            `{phpstan.neon,phpstan.neon.dist}`
-          ),
+        new RelativePattern(getWorkspacePath(), this.settings.configPath),
         (uri, eventName) => {
           if (!this.store.fileWatcher.enabled) return;
           const path = sanitizeFsPath(uri.fsPath);

src/utils/phpstan.ts

@@ -1,7 +1,5 @@
-import { checkFile } from "./fs";
 import { parseNeonFile } from "./neon";
 import { resolvePath } from "./path";
-import { join } from "path";
 
 export type PHPStanAnalyseResult = {
   totals: {
@@ -49,18 +47,6 @@ export async function parsePHPStanConfigFile(
   return normalizePHPStanConfig(config, env.currentWorkingDirectory);
 }
 
-export async function findPHPStanConfigPath(
-  cwd: string
-): Promise<string | undefined> {
-  const baseNames = ["phpstan.neon", "phpstan.neon.dist"];
-  for (const basename of baseNames) {
-    const path = join(cwd, basename);
-    if (await checkFile(path)) {
-      return path;
-    }
-  }
-}
-
 export function normalizePHPStanConfig(
   config: PHPStanConfig,
   cwd: string