add http_client setBasicAuth #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twose
requested changes
Apr 30, 2019
swoole_http_client_coro.cc
Outdated
| ZEND_PARSE_PARAMETERS_END_EX(RETURN_FALSE); | ||
|
|
||
| std::string str = phc->get_basic_auth_encode(name, nameLen, passwd, passwdLen); | ||
| zval *zheaders = sw_zend_read_property(swoole_http_client_coro_ce, getThis(), ZEND_STRL("requestHeaders"), 1); |
There was a problem hiding this comment.
use sw_zend_read_property_array, slient = 0
swoole_http_client_coro.cc
Outdated
| @@ -1404,6 +1413,30 @@ bool http_client::close() | |||
| return false; | |||
| } | |||
|
|
|||
| std::string http_client::get_basic_auth_encode(char *name, size_t nameLen, char *passwd, size_t passwdLen){ | |||
There was a problem hiding this comment.
- code style (use snake name, put the brace on a new line)
- keep same with PHP API (
set_basic_auth) or let it be a static function - use
emalloc(this module has already been strongly associated with PHP) - why not using
sw_sprintf?
swoole_http_client_coro.cc
Outdated
| size_t outputLen = BASE64_ENCODE_OUT_SIZE(inputLen); | ||
| char *input = new char[inputLen + 1]; | ||
| char *output = new char[outputLen + 7]; | ||
| if(input == nullptr || output == nullptr) return std::string(); |
There was a problem hiding this comment.
C++ will throw an exception instead of return nullptr
swoole_http_client_coro.cc
Outdated
| static PHP_METHOD(swoole_http_client_coro, setBasicAuth) | ||
| { | ||
| http_client* phc = swoole_get_phc(getThis()); | ||
| char *name = nullptr, *passwd = nullptr; |
There was a problem hiding this comment.
For required parameters, initialization is not necessary
| $pm = new ProcessManager; | ||
| $pm->parentFunc = function ($pid) use ($pm) { | ||
| go(function () use ($pm) { | ||
| echo httpGetBody("http://127.0.0.1:{$pm->getFreePort()}/"); |
There was a problem hiding this comment.
use http://httpbin.org (HTTPBIN_SERVER_HOST, HTTPBIN_SERVER_PORT), process manager is unnecessary
twose
requested changes
Apr 30, 2019
swoole_http_client_coro.cc
Outdated
| zval *value = NULL; | ||
| char *key; | ||
| size_t keylen, keytype; | ||
| if(Z_TYPE_P(zheaders) == IS_NULL) array_init(zheaders); |
added 2 commits
April 30, 2019 16:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support http client setBasicAuth