graphics/deko3d: fix and simplify rbtree code #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fincs
reviewed
Sep 11, 2022
| }; | ||
| // This is technically UB, but basically every compiler worth using admits it as an extension | ||
| return (ClassT*)((intptr_t)member - whatever{ptr}.offset); | ||
| return (ClassT *)((char *)member - (char *)&((ClassT *)0->*ptr)); |
There was a problem hiding this comment.
This is still UB fwiw. I'd say the original version of this function is easier to read and does not involve dereferencing a null pointer.
fincs
reviewed
Sep 11, 2022
| if (mode == UpperBound && node) | ||
| node = walk(node, N::Right); | ||
| else if (!node && parent) | ||
| node = &parent->left() == &point ? parent : walk(parent, N::Right); |
There was a problem hiding this comment.
Is this ternary actually correct for UpperBound mode?
There was a problem hiding this comment.
Please let me know if there is any problem.
There was a problem hiding this comment.
I was mostly asking how did you arrive to that simplification, as I'm currently struggling to wrap my head around this code :p
There was a problem hiding this comment.
After some analysis, I believe this code to be correct.
xfangfang
added a commit
to xfangfang/borealis
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #100.