Fix bugs in planning reserve margin. One bug was a typo in accessing a model component. The other was a problem with default capacity value for solar plants that have capacity factors greater than 1.0 (a frequently observed event on partly-cloudy days). I took a conservative approach of capping capacity value at 100% of nameplate capacity. An alternate approach would be changing the domain of gen_capacity_value from PercentFraction to NonNegativeReals.

Author: josiahjohnston

switch_model/balancing/planning_reserves.py

@@ -194,7 +194,9 @@ def gen_capacity_value_default(m, g, t):
         if not m.gen_can_provide_cap_reserves[g]:
             return 0.0
         elif g in m.VARIABLE_GENS:
-            return m.gen_max_capacity_factor[g, t]
+            # This can be > 1 (Ex solar on partly cloudy days). Take a
+            # conservative approach of capping at 100% of nameplate capacity.
+            return min(1.0, m.gen_max_capacity_factor[g, t])
         else:
             return 1.0
     model.gen_capacity_value = Param(
@@ -221,10 +223,8 @@ def AvailableReserveCapacity_rule(m, prr, t):
         ]
         for g in GENS:
             # Storage is only credited with its expected output
-            # Note: this code appears to have no users, since it references
-            # DispatchGen, which doesn't exist (should be m.DispatchGen).
             if g in getattr(m, 'STORAGE_GENS', set()):
-                reserve_cap += DispatchGen[g, t] - m.ChargeStorage[g, t]
+                reserve_cap += m.DispatchGen[g, t] - m.ChargeStorage[g, t]
             # If local_td is included with DER modeling, avoid allocating
             # distributed generation to central grid capacity because it will
             # be credited with adjusting load at the distribution node.