Fix CMake export #101
Merged
Fix CMake export #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kateinoigakukun
added a commit
to kabiroberai/swift
that referenced
this pull request
Jul 15, 2024
To include a CMake fix swiftwasm/WasmKit#101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously appending to
SWIFT_EXPORTSwhich has a special meaning for in-tree swiftc builds. This was causing us to export WasmKit to all consumers of the Swift Compiler via CMake. Specifically, this resulted in failing builds of Swift's LLDB fork: see swiftlang/swift#73031 (comment).We can fix this by using a different property name.