Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc comments for public APIs (Part 2) #57

Merged
merged 7 commits into from
Sep 16, 2020
Merged

Add doc comments for public APIs (Part 2) #57

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2f818cb
Add doc comments for public APIs (Part 2)
kateinoigakukun Sep 16, 2020
d0160d4
Update Sources/JavaScriptKit/BasicObjects/JSArray.swift
kateinoigakukun Sep 16, 2020
d2a13fb
Update Sources/JavaScriptKit/BasicObjects/JSArray.swift
kateinoigakukun Sep 16, 2020
ab0d6a8
Update Sources/JavaScriptKit/BasicObjects/JSTypedArray.swift
kateinoigakukun Sep 16, 2020
a3c8652
Update Sources/JavaScriptKit/BasicObjects/JSTypedArray.swift
kateinoigakukun Sep 16, 2020
0f4f2e2
Update Sources/JavaScriptKit/JSValueConvertible.swift
kateinoigakukun Sep 16, 2020
2c9299d
Update Sources/JavaScriptKit/JSValueDecoder.swift
kateinoigakukun Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Sources/JavaScriptKit/BasicObjects/JSArray.swift 
Co-authored-by: Max Desiatov <max@desiatov.com>
  • Loading branch information
@kateinoigakukun @MaxDesiatov
kateinoigakukun and MaxDesiatov authored Sep 16, 2020
commit d2a13fb36892848affb9e3cbec0d7fc387c61e9a
2 changes: 1 addition & 1 deletion Sources/JavaScriptKit/BasicObjects/JSArray.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class JSArray {
/// Construct a `JSArray` from Array `JSObject`.
/// Return `nil` if the object is not an Array.
///
/// - Parameter object: A `JSObject` expected to be Array of JavaScript
/// - Parameter object: A `JSObject` expected to be a JavaScript Array
public init?(_ ref: JSObject) {
guard Self.isArray(ref) else { return nil }
self.ref = ref
Expand Down