PackageToJS: Remove "playwright" dependency declaration from generated package.json #454
+0
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d package.json We alreawdy recommend users to declare playwright dep in their own package.json, so it doesn't make sense to have it declared here as well. ``` Playwright is not available in the current environment. Please run the following command to install it: $ npm install playwright && npx playwright install chromium ``` Actually, the declaration also makes things more complicated when users already have playwright dependency declared with a different version. Given that users unlikely commit the generated package.json into their repositories, it can't be a part of "workspace" either, so there is no benefit to have it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We alreawdy recommend users to declare playwright dep in their own package.json, so it doesn't make sense to have it declared here as well.
Actually, the declaration also makes things more complicated when users already have playwright dependency declared with a different version. Given that users unlikely commit the generated package.json into their repositories, it can't be a part of "workspace" either, so there is no benefit to have it here.