Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JavaScriptEventLoopTestSupport module to install executor #213

Merged
merged 9 commits into from
Sep 30, 2022
Merged

Add JavaScriptEventLoopTestSupport module to install executor #213

merged 9 commits into from
Sep 30, 2022

Conversation

kateinoigakukun
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 30, 2022 •
edited
Loading

Time Change: +31ms (0%)

Total Time: 22,482ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 28ms -6ms (21%) 🎉
Serialization/JavaScript function call through Wasm import with int 25ms -3ms (10%) 👏
View Unchanged
Test name Duration Change
Serialization/JavaScript function call from Swift 248ms +12ms (4%)
Serialization/Swift Int to JavaScript with assignment 546ms -2ms (0%)
Serialization/Swift Int to JavaScript with call 1,638ms +8ms (0%)
Serialization/JavaScript Number to Swift Int 598ms +23ms (3%)
Serialization/Swift String to JavaScript with assignment 635ms -4ms (0%)
Serialization/Swift String to JavaScript with call 1,770ms -2ms (0%)
Serialization/JavaScript String to Swift String 7,018ms -99ms (1%)
Object heap/Increment and decrement RC 9,959ms +111ms (1%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 2ms
Serialization/Assign JavaScript number directly 3ms
Serialization/Call with JavaScript number directly 5ms
Serialization/Write JavaScript string directly 3ms
Serialization/Call with JavaScript string directly 3ms

@kateinoigakukun kateinoigakukun force-pushed the katei/add-jsel-test-support branch from ef397f4 to 6cdac18 Compare September 30, 2022 14:01
@kateinoigakukun kateinoigakukun force-pushed the katei/add-jsel-test-support branch from 6cdac18 to b34c15f Compare September 30, 2022 14:03
@kateinoigakukun
Copy link
Member Author

Thank you for quick review :)

@kateinoigakukun kateinoigakukun merged commit a549f58 into main Sep 30, 2022
@kateinoigakukun kateinoigakukun deleted the katei/add-jsel-test-support branch September 30, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-f1 j-f1 j-f1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kateinoigakukun @j-f1