Skip to content

Conversation

kateinoigakukun
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 8, 2021

Time Change: +3,569ms (23%) 🚨

Total Time: 15,218.75ms

Test name Duration Change
Serialization/Write JavaScript number directly 274.75ms +46.25ms (16%) ⚠️
Serialization/Write JavaScript string directly 299.5ms +64.5ms (21%) 🚨
Serialization/Swift Int to JavaScript 4,967.75ms +1,286ms (25%) 🚨
Serialization/Swift String to JavaScript 5,024.5ms +1,225.75ms (24%) 🚨
Object heap/Increment and decrement RC 4,652.25ms +946.5ms (20%) 🚨

performance-action

@MaxDesiatov MaxDesiatov marked this pull request as ready for review August 22, 2021 18:44
@MaxDesiatov
Copy link
Member

@kateinoigakukun I guess we should also test with Ubuntu 20.04, but I don't see where the exact Ubuntu version is passed from the matrix. I don't think swiftenv detects that automatically, does it?

@kateinoigakukun
Copy link
Member Author

@MaxDesiatov swiftenv doesn't anything around arch but install script does it

if [ $(grep RELEASE /etc/lsb-release) == "DISTRIB_RELEASE=18.04" ]; then
toolchain_download="$swift_tag-ubuntu18.04_x86_64.tar.gz"
elif [ $(grep RELEASE /etc/lsb-release) == "DISTRIB_RELEASE=20.04" ]; then
toolchain_download="$swift_tag-ubuntu20.04_x86_64.tar.gz"
else

@MaxDesiatov MaxDesiatov changed the title Test for multiple version of toolchains Test with multiple toolchain versions Sep 1, 2021
@kateinoigakukun kateinoigakukun merged commit c5074e7 into main Sep 1, 2021
@kateinoigakukun kateinoigakukun deleted the katei/5.4-compatibility branch September 1, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants