Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major API change on JSClosure #113

Merged
merged 11 commits into from
Jan 4, 2021
Merged

Major API change on JSClosure #113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4c9b876
Major change on JSClosure
kateinoigakukun Jan 2, 2021
df7ff62
Keep JSClosure overloads as derepcated initializer
kateinoigakukun Jan 2, 2021
e67b03e
Apply suggestions from code review
kateinoigakukun Jan 2, 2021
65658bd
Update Sources/JavaScriptKit/FundamentalObjects/JSClosure.swift
kateinoigakukun Jan 3, 2021
3b93924
Apply suggestions from code review
kateinoigakukun Jan 3, 2021
efd633e
Use JSOneshotClosure in JSTimer
kateinoigakukun Jan 3, 2021
76193c7
Remove JSClosure.callAsFunction
kateinoigakukun Jan 3, 2021
2f84381
Use JSOneshotClosure instead of JSClosure in JSPromise
kateinoigakukun Jan 3, 2021
110b72d
Fix compatibility build target dir
kateinoigakukun Jan 3, 2021
aed4312
Add compatibility method for JSValue.function(_:JSClosure)
kateinoigakukun Jan 3, 2021
0896483
Update Sources/JavaScriptKit/JSValue.swift
kateinoigakukun Jan 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add compatibility method for JSValue.function(_:JSClosure)
  • Loading branch information
@kateinoigakukun
kateinoigakukun committed Jan 3, 2021
commit aed4312ddf77d1cfe81c186ff352c03cd5f8b505
2 changes: 1 addition & 1 deletion Example/JavaScriptKitExample/Sources/JavaScriptKitExample/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ buttonElement.innerText = "Click me!"
let listener = JSClosure { _ in
alert("Swift is running on browser!")
}
buttonElement.onclick = .function(listener)
buttonElement.onclick = .object(listener)

_ = document.body.appendChild(buttonElement)
5 changes: 5 additions & 0 deletions Sources/JavaScriptKit/JSValue.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,11 @@ extension JSValue {
public static func function(_ body: @escaping ([JSValue]) -> JSValue) -> JSValue {
.object(JSClosure(body))
}

@available(*, deprecated, renamed: "object", message: "JSClosure is not a subclass of JSFunction now")
kateinoigakukun marked this conversation as resolved.
Show resolved Hide resolved
public static func function(_ closure: JSClosure) -> JSValue {
.object(closure)
}
}

extension JSValue: ExpressibleByStringLiteral {
Expand Down