ByteArrayOutputStream API never throws

Author: tonyfreeman

Sources/Stream/Library/ByteArrayStream/ByteArrayOutputStream+StreamWriter.swift

@@ -3,41 +3,34 @@ extension ByteArrayOutputStream: StreamWriter {
         return bytes.count - position
     }
 
-    public func write(_ byte: UInt8) throws {
+    public func write(_ byte: UInt8) {
         bytes.append(byte)
     }
 
-    public func write<T: FixedWidthInteger>(_ value: T) throws {
+    public func write<T: FixedWidthInteger>(_ value: T) {
         var value = value.bigEndian
         withUnsafeBytes(of: &value) { buffer in
             bytes.append(contentsOf: buffer)
         }
     }
 
-    public func write(_ bytes: UnsafeRawPointer, byteCount: Int) throws {
-        var written = 0
-        while written < byteCount {
-            let count = try write(from: bytes, byteCount: byteCount)
-            guard count > 0 else {
-                throw StreamError.insufficientData
-            }
-            written += count
-        }
+    public func write(_ bytes: UnsafeRawPointer, byteCount: Int) {
+        _ = write(from: bytes, byteCount: byteCount)
     }
 
     // MARK: Override StreamWriter async functions
 
-    public func write(_ bytes: UnsafeRawBufferPointer) throws {
-        try write(bytes.baseAddress!, byteCount: bytes.count)
+    public func write(_ bytes: UnsafeRawBufferPointer) {
+        write(bytes.baseAddress!, byteCount: bytes.count)
     }
 
-    public func write(_ bytes: [UInt8]) throws {
-        try write(bytes, byteCount: bytes.count)
+    public func write(_ bytes: [UInt8]) {
+        write(bytes, byteCount: bytes.count)
     }
 
-    public func write(_ string: String) throws {
-        try write([UInt8](string.utf8))
+    public func write(_ string: String) {
+        write([UInt8](string.utf8))
     }
 
-    public func flush() throws {}
+    public func flush() {}
 }

Sources/Stream/Library/ByteArrayStream/ByteArrayOutputStream.swift

@@ -11,7 +11,7 @@ public class ByteArrayOutputStream: OutputStream {
     @inline(__always)
     public func write(
         from buffer: UnsafeRawPointer,
-        byteCount: Int) throws -> Int
+        byteCount: Int) -> Int
     {
         bytes.append(contentsOf: UnsafeRawBufferPointer(
             start: buffer,

Tests/Stream/ByteArrayOutputStream/main.swift

@@ -4,22 +4,22 @@ import Test
 test.case("ByteArrayOutputStream") {
     let outputStream  = ByteArrayOutputStream()
     let bytes = [UInt8]()
-    expect(try outputStream.write(from: bytes, byteCount: 0) == 0)
+    expect(outputStream.write(from: bytes, byteCount: 0) == 0)
 }
 
 test.case("ByteArrayOutputStream Numeric") {
     let outputStream  = ByteArrayOutputStream()
 
-    try outputStream.write(Int(-1))
-    try outputStream.write(Int8(-2))
-    try outputStream.write(Int16(-3))
-    try outputStream.write(Int32(-4))
-    try outputStream.write(Int64(-5))
-    try outputStream.write(UInt(1))
-    try outputStream.write(UInt8(2))
-    try outputStream.write(UInt16(3))
-    try outputStream.write(UInt32(4))
-    try outputStream.write(UInt64(5))
+    outputStream.write(Int(-1))
+    outputStream.write(Int8(-2))
+    outputStream.write(Int16(-3))
+    outputStream.write(Int32(-4))
+    outputStream.write(Int64(-5))
+    outputStream.write(UInt(1))
+    outputStream.write(UInt8(2))
+    outputStream.write(UInt16(3))
+    outputStream.write(UInt32(4))
+    outputStream.write(UInt64(5))
 
     let inputStream  = ByteArrayInputStream(outputStream.bytes)