Properly handle toolchains from Command Line Tools on macOS #1936
+344
−399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbastien
force-pushed
the
fix-command-line-tools
branch
from
d235a38 to
c2116fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjust toolchain discovery to detect whether or not the
swiftbinary is anxcrunshim. This allows us to detect and usexcrunfor both Xcode and Command Line Tools toolchains on macOS.The extension was only using
xcrunto find toolchain executables when it detected that the toolchain was inside an Xcode application. However, toolchains can also come from installing the command line tools withxcode-select --install.Issue: #1077
Tasks
[ ] Documentation has been updated