Add --use flag to install #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
approved these changes
Oct 13, 2023
Sources/Swiftly/Update.swift
Outdated
| @@ -56,7 +56,7 @@ struct Update: SwiftlyCommand { | |||
| } | |||
|
|
|||
| print("updating \(oldToolchain) -> \(newToolchain)") | |||
| try await Install.execute(version: newToolchain) | |||
| try await Install.execute(version: newToolchain, use: false) | |||
There was a problem hiding this comment.
I know update hasn't been merged yet but shouldn't swiftly update also default to using the newly updated toolchain.
There was a problem hiding this comment.
This is just in here to have the existing update code compile, but it'll be changed in #67. The planned logic for this is if the toolchain being updated is the one that is in use, then the newly installed one will be used, otherwise no.
|
Going to wait to merge this until #67 goes in so that I can reuse the download mocking for the test I added here. The RHEL 9 failure is due to a missing download on that platform, but we don't actually need to download anything for this test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71