Make release package file names more uname friendly on Linux #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test macOS |
justice-adams-apple
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When operating on Linux there are different variants of swiftly for either x86_64 or aarch64 architectures. It is likely that people will need to make platform-independent samples, such as on swift.org to download the correct binary package for their system. By making the filename reflect what
uname -mon the system scripts can use this to make sure that they download the correct release package and also they can download both without collisions. Fix the release package filename for linux x86_64 to include the architecture in the file name so that the filename matches the following:swiftly-<VERSION>-$(uname -m).tar.gz