Fix package install detection for packages that are partially installed #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcgee1024
force-pushed
the
check_purged_pkgs
branch
from
809392d to
6de61ad
Compare
|
@swift-ci test macOS |
On Debian/Ubuntu Linux that use the dpkg/apt package manager there is a possibility that a package is not in a fully installed state. It can be removed, leaving its configuration files, or the install could have failed. Check rigorously that the package is fully installed without error before producing the command-line. Also, correct the install command to use apt-get instead of apt since that command-line is guaranteed to be stable.
cmcgee1024
force-pushed
the
check_purged_pkgs
branch
from
6de61ad to
685c7b7
Compare
|
@swift-ci test macOS |
|
macOS tests are passing: |
justice-adams-apple
approved these changes
Oct 24, 2024
| // |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) | ||
| // ||/ | ||
| // ii pkgfoo 1.0.0ubuntu12 My description goes here.... | ||
| return pkgList.contains("\nii ") |
There was a problem hiding this comment.
This works, but is there something we could look for which is more indicative of an error than \nii? 🤔 If not, LGTM
There was a problem hiding this comment.
If the dpkg -l command fails then that is treated as an indication that the package isn't installed, which throws an error caught below. It's just that this output can be that the package is partially installed, which requires this output check here. I don't think that there's much else we can do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Debian/Ubuntu Linux that use the dpkg/apt package manager there is a possibility that a package is not in a fully installed state. It can be removed, leaving its configuration files, or the install could have failed. Check rigorously that the package is fully installed without error before producing the command-line.
Also, correct the install command to use apt-get instead of apt since that command-line is guaranteed to be stable.