Add signature cert and package identifier parameters to package script #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building macOS packages with pkgbuild, a signing certificate needs to be provided up-front, as is the package identifier. Change the package script so that it can accept the location of the certificate and override the package identifier.
|
@swift-ci test macOS |
|
@swift-ci test macOS |
|
macOS tests are all passing: |
|
@cmcgee1024 Do you know what's going on here for macOS failure? |
@shahmishal I don't have any insights into this error, but there is some analysis here: #172 (comment) |
justice-adams-apple
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building macOS packages with pkgbuild, a signing certificate needs to be provided up-front, as is the package identifier. Change the package script so that it can accept the location of the certificate and override the package identifier.