Enhancements to the release build script #165
Conversation
cmcgee1024
force-pushed
the
release-script-enhancement
branch
3 times, most recently
from
f6d6900 to
fd783ca
Compare
Add macOS support for making releases there.
Rewrite the release builder script in Swift for better reproducibility
and ergonomics. It runs using this command:
swift run build-swiftly-release
Perform necessary system checks up front so that anyone running the
script can make any necessary adjustments so that the release can be
built.
Print the location of the final release product file at the end for
easy of finding the path to copy to the final release destination.
cmcgee1024
force-pushed
the
release-script-enhancement
branch
from
fd783ca to
5237b8e
Compare
|
@swift-ci test macOS |
|
Addresses a portion of #146 |
|
TODO: include all of the relevant licenses into the release artifact, including libarchive. |
|
@swift-ci test macOS |
Fix all of the swift.org urls so that they use www.swift.org to avoid redirection
| #if arch(arm64) | ||
| return | ||
| #else | ||
| throw Error(message: "Releases must be made from an Apple Silicon macOS system to make universal binaries.") |
There was a problem hiding this comment.
This does not appear to be a restriction, so just remove this.
| let cwd = FileManager.default.currentDirectoryPath | ||
|
|
||
| // Copy the swiftly license to the bundle | ||
| try FileManager.default.copyItem(atPath: cwd + "/LICENSE.txt", toPath: licenseDir + "/LICENSE.txt") |
There was a problem hiding this comment.
The license file from swiftly should be the sole license file at the root of the archive.
…s check Scale back the license gathering to only including the swiftly license Add a check for the presence of the which command used to find the other tools
|
We should update the logic to allow inputs for identifier and sign cert for macOS |
| * Build on an Amazon Linux 2 image for x86_64 | ||
| * Build on an Amazon Linux 2 image for arm64 |
There was a problem hiding this comment.
Is there a reason we are only building for Amazon Linux 2 image compared to all platforms? Also, should we use static sdk to build for multiple platforms?
There was a problem hiding this comment.
Amazon Linux 2 has the oldest glibc of the supported Linux distributions, so compiling with it will help guarantee binary compatibility with the rest. We have an issue open to use static Linux sdk / musl #119 for a future release. In the meantime time, the release needs to be made from AL2.
Add macOS support for making releases there.
Rewrite the release builder script in Swift for better reproducibility and ergonomics. It runs using this command:
Perform necessary system checks up front so that anyone running the script can make any necessary adjustments so that the release can be built.
Print the location of the final release product file at the end for easy of finding the path to copy to the final release destination.