Skip to content

macOS: Generate config.json in swiftly-install.sh #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

BrianHenryIE
Copy link

@BrianHenryIE BrianHenryIE commented Jul 17, 2024

Fix #136

Currently, on macOS, no config.json is created by swiftly-install.sh and swiftly crashes when run.

This PR creates it using the values advised in #121 (comment)

The platform.architecture key has to be explicitly absent, i.e. not even an empty string, for the correct URLs to be generated.

% swiftly install 5.7    

Fetching the latest stable Swift 5.7 release...
Installing Swift 5.7.3
                                              Downloading Swift 5.7.3
100% [================================================================================================]
Downloaded 963.4 MiB of 963.4 MiB
Installing package in user home directory...
installer: Package name is Swift Open Source Xcode Toolchain
installer: Installing at base path /Users/brianhenry
installer: The install was successful.
Swift 5.7.3 installed successfully!

Edit:

  • I'm happy to write tests if necessary, but I think maybe it's more a matter of adding a macOS test environment which runs all existing tests

@cmcgee1024
Copy link
Member

Thanks @BrianHenryIE. As you've noted, there are some problems with the swiftly install shell script with macOS. We're currently in the process of migrating the installation logic of the shell script into swiftly itself, which should resolve this problem, and a few others. See #127 for more details.

@BrianHenryIE
Copy link
Author

Sounds good. I've nothing to report about the tool itself on macOS – everything is running smoothly. I've updated nightlies a couple of times with it.

@adam-fowler
Copy link
Contributor

Now that #127 has been merged we can probably close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS swiftly-install.sh does not create config.json
3 participants