Fix NIOTooManyBytesError that sometimes occurs during XCTests #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, when not using a GitHub access token, the API returns a content-length that is shorter than the true length of the response body, which causes NIO to throw the error because there are remaining bytes in the payload. The upTo parameter for collect is not intended to be used in this way. It acts as an upper limit to the size of a reasonable response, which prevents excessive memory consumption attempting to process it. Instead of setting the upTo to the length given by the response, set the upper limit to something static that is an expected limit to the size that is expected. In the case of JSON, set it to 1MB.
adam-fowler
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, when not using a GitHub access token, the API returns a content-length that is shorter than the true length of the response body, which causes NIO to throw the error because there are remaining bytes in the payload.
The upTo parameter for collect is not intended to be used in this way. It acts as an upper limit to the size of a reasonable response, which prevents excessive memory consumption attempting to process it.
Instead of setting the upTo to the length given by the response, set the upper limit to something static that is an expected limit to the size that is expected. In the case of JSON, set it to 1MB.
This fixes #128