Skip to content

build.ps1: add swift-tools-protocols #85078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

build.ps1: add swift-tools-protocols #85078

wants to merge 1 commit into from
+32 −4

Conversation

@owenv
Copy link
Contributor

@owenv owenv commented Oct 23, 2025

This will be a sourcekit-lsp dependency starting with swiftlang/sourcekit-lsp#2324, a SwiftPM dependency starting with swiftlang/swift-package-manager#9129, and a swift-build dependency starting with swiftlang/swift-build#782. Update the windows build script accordingly

@owenv
Copy link
Contributor Author

owenv commented Oct 23, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv owenv force-pushed the owenv/tools-protocols-windows branch from 2e16a23 to 2857499 Compare October 23, 2025 16:06
@owenv
Copy link
Contributor Author

owenv commented Oct 23, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

2 similar comments
@owenv
Copy link
Contributor Author

owenv commented Oct 23, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv
Copy link
Contributor Author

owenv commented Oct 23, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

compnerd
compnerd reviewed Oct 24, 2025
View reviewed changes
utils/build.ps1 Outdated
-SwiftSDK $SDKROOT `
-BuildTargets default `
-Defines @{
BUILD_SHARED_LIBS = "NO";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a single use library? i.e. does only one product use the library? If not, we should consider the shared version with numbers on the size impact - that is verify that static linking is smaller than the dynamic linking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's going to get linked into at least two executables, so I will probably end up flipping it to a shared library but I haven't tested it yet

@owenv owenv force-pushed the owenv/tools-protocols-windows branch from 2857499 to 57a58c7 Compare October 24, 2025 16:34
@owenv
Copy link
Contributor Author

owenv commented Oct 24, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

4 similar comments
@owenv
Copy link
Contributor Author

owenv commented Oct 24, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv
Copy link
Contributor Author

owenv commented Oct 25, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv
Copy link
Contributor Author

owenv commented Oct 25, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv
Copy link
Contributor Author

owenv commented Oct 25, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv owenv force-pushed the owenv/tools-protocols-windows branch from 57a58c7 to bdcd59d Compare October 26, 2025 02:25
@owenv
Copy link
Contributor Author

owenv commented Oct 26, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv owenv force-pushed the owenv/tools-protocols-windows branch from bdcd59d to a4ac2dc Compare October 26, 2025 17:11
@owenv
Copy link
Contributor Author

owenv commented Oct 26, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv owenv force-pushed the owenv/tools-protocols-windows branch from a4ac2dc to 8876942 Compare October 26, 2025 21:00
@owenv
Copy link
Contributor Author

owenv commented Oct 26, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv owenv force-pushed the owenv/tools-protocols-windows branch from 8876942 to 5d351dd Compare October 27, 2025 03:52
@owenv
Copy link
Contributor Author

owenv commented Oct 27, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv owenv force-pushed the owenv/tools-protocols-windows branch from 5d351dd to 642d724 Compare October 27, 2025 16:17
@owenv
Copy link
Contributor Author

owenv commented Oct 27, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv owenv mentioned this pull request Oct 27, 2025
Open
@owenv owenv force-pushed the owenv/tools-protocols-windows branch from 642d724 to 220b235 Compare October 27, 2025 20:20
@owenv
Copy link
Contributor Author

owenv commented Oct 27, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv owenv force-pushed the owenv/tools-protocols-windows branch from 220b235 to 87ea24c Compare October 28, 2025 00:03
@owenv
Copy link
Contributor Author

owenv commented Oct 28, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

1 similar comment
@owenv
Copy link
Contributor Author

owenv commented Oct 28, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv owenv mentioned this pull request Oct 28, 2025
Merged
@owenv owenv force-pushed the owenv/tools-protocols-windows branch from 87ea24c to 1c299c5 Compare October 28, 2025 16:27
@owenv
Copy link
Contributor Author

owenv commented Oct 28, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

1 similar comment
@owenv
Copy link
Contributor Author

owenv commented Oct 28, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv owenv mentioned this pull request Oct 29, 2025
Open
@owenv owenv force-pushed the owenv/tools-protocols-windows branch from 1c299c5 to 1df7f8d Compare October 29, 2025 03:59
@owenv
Copy link
Contributor Author

owenv commented Oct 29, 2025

swiftlang/sourcekit-lsp#2324
swiftlang/swift-installer-scripts#474
@swift-ci please smoke test

@owenv
Copy link
Contributor Author

owenv commented Oct 29, 2025

swiftlang/sourcekit-lsp#2324
swiftlang/swift-installer-scripts#474
@swift-ci please build toolchain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compnerd compnerd compnerd left review comments

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal will be requested when the pull request is marked ready for review shahmishal is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@owenv @compnerd