Skip to content

[IRGen] Fix placeholder logic for emission of conditionally inverted … #82347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

drexin
Copy link
Contributor

@drexin drexin commented Jun 18, 2025

…protocols

rdar://153681688

Instead fo counting the actual conformances, the logic took the size of the bit field, i.e. used the highest set bit, so when a type had a conditional conformance only on ~Escapable, but not on ~Copyable, it would still add 2 placeholders, but only fill one.

…protocols

rdar://153681688

Instead fo counting the actual conformances, the logic took the size of the bit field, i.e. used the highest set bit, so when a type had a conditional conformance only on ~Escapable, but not on ~Copyable, it would still add 2 placeholders, but only fill one.
@drexin drexin requested a review from rjmccall as a code owner June 18, 2025 18:31
@drexin
Copy link
Contributor Author

drexin commented Jun 18, 2025

@swift-ci smoke test

@drexin
Copy link
Contributor Author

drexin commented Jun 18, 2025

@swift-ci test

Copy link
Contributor

@meg-gupta meg-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@drexin drexin merged commit 6db11b6 into swiftlang:main Jun 19, 2025
5 checks passed
@drexin drexin deleted the wip-153681688 branch June 19, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants