Skip to content

[wasm] Build and install Foundation for Wasm SDK #82285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kateinoigakukun
Copy link
Member

No description provided.

@kateinoigakukun
Copy link
Member Author

@swift-ci smoke test

Comment on lines 214 to 223
self._build_libxml2(swift_host_triple, has_pthread, wasi_sysroot)
self._build_foundation(swift_host_triple, has_pthread, wasi_sysroot)
Copy link
Contributor

@MaxDesiatov MaxDesiatov Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Foundation built for any other platform for smoke test CI trigger? If not, I think we should make _build_libxml2 and _build_foundation conditional on --foundation passed to build-script or included in a preset

Copy link
Member Author

@kateinoigakukun kateinoigakukun Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke test builds Foundation for the host platform as well.

@MaxDesiatov
Copy link
Contributor

@swift-ci smoke test macos

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the trade-off is worth it for now. We can address build time regressions later by making the build-script invocations concurrent in the future.

@MaxDesiatov MaxDesiatov added the build-script Area → utils: The build script label Jun 17, 2025
@MaxDesiatov MaxDesiatov requested a review from bnbarham June 17, 2025 08:42
@MaxDesiatov MaxDesiatov added Foundation WebAssembly Platform: WebAssembly WASI WebAssembly System Interface support labels Jun 17, 2025
@kateinoigakukun
Copy link
Member Author

@swift-ci smoke test Linux platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-script Area → utils: The build script Foundation WASI WebAssembly System Interface support WebAssembly Platform: WebAssembly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants