Skip to content

[DO NOT MERGE] Logging to test -verify-additional-file on Windows #80549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[DO NOT MERGE] Logging to test -verify-additional-file on Windows #80549

wants to merge 2 commits into from

Conversation

j-hui
Copy link
Contributor

@j-hui j-hui commented Apr 4, 2025

No description provided.

@j-hui
Copy link
Contributor Author

j-hui commented Apr 4, 2025

@swift-ci please smoke test windows platform

@j-hui
Copy link
Contributor Author

j-hui commented Apr 5, 2025

@swift-ci please smoke test windows platform

@j-hui
Copy link
Contributor Author

j-hui commented Apr 6, 2025

The relevant issue is this:

# .---command stderr------------
# | Got additional file: [[42]]::C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\test\Interop\Cxx\foreign-reference/Inputs/inheritance.h
# | Captured error in [[2]]::C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\test\Interop\Cxx\foreign-reference/Inputs\inheritance.h: 125
...

2 and 42 are distinct buffer IDs that refer to the same file, but via different paths (specifically, / vs \). I'll fix this in a separate PR.

@j-hui j-hui closed this Apr 6, 2025
@j-hui j-hui deleted the fix-verify-additional-file-windows branch April 9, 2025 18:28
@j-hui j-hui mentioned this pull request Apr 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver will be requested when the pull request is marked ready for review zoecarver is a code owner

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan will be requested when the pull request is marked ready for review egorzhdan is a code owner

@Xazax-hun Xazax-hun Awaiting requested review from Xazax-hun Xazax-hun will be requested when the pull request is marked ready for review Xazax-hun is a code owner

@fahadnayyar fahadnayyar Awaiting requested review from fahadnayyar fahadnayyar will be requested when the pull request is marked ready for review fahadnayyar is a code owner

@susmonteiro susmonteiro Awaiting requested review from susmonteiro susmonteiro will be requested when the pull request is marked ready for review susmonteiro is a code owner

@hnrklssn hnrklssn Awaiting requested review from hnrklssn hnrklssn will be requested when the pull request is marked ready for review hnrklssn is a code owner

@artemcm artemcm Awaiting requested review from artemcm artemcm will be requested when the pull request is marked ready for review artemcm is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli will be requested when the pull request is marked ready for review tshortli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@j-hui