AST: Teach AvailabilityContext to represent version-less availability #79807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
tshortli
force-pushed
the
availability-context-available-custom-domains
branch
from
d617383 to
6007a19
Compare
… queries. Introduction, deprecation, and obsoleteion ranges should only be returned by the accessors on `SemanticAvailableAttr` when the attribute actually has an affect on the corresponding kind of availability.
tshortli
force-pushed
the
availability-context-available-custom-domains
branch
from
6007a19 to
51a77d2
Compare
tshortli
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
…ersion. This allows `X is only available in` diagnostics to be emitted for potential unavailability in domains that do not support versioning.
tshortli
force-pushed
the
availability-context-available-custom-domains
branch
2 times, most recently
from
2523b69 to
56e5d8a
Compare
|
@swift-ci please test Linux |
This enables potential unavailability diagnostics to be emitted for decls that are only available in version-less domains.
tshortli
force-pushed
the
availability-context-available-custom-domains
branch
from
56e5d8a to
0462cfd
Compare
|
@swift-ci please smoke test |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 20, 2025
swiftlang#79807 caused a regression in which `AvailabilityContext` stopped tracking the available version range for the active platform domain for certain platforms. Fix this by reverting to checking `AvailabilityDomain::isActive()` to determine when a given platform `AvailabilityDomain` represents the target platform. The compiler's existing mapping from target triple to platform domain is incomplete and it's not clear to me whether fixing that could cause other regressions. Resolves rdar://147413616.
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 20, 2025
swiftlang#79807 caused a regression in which `AvailabilityContext` stopped tracking the available version range for the active platform domain for certain platforms. Fix this by reverting to checking `AvailabilityDomain::isActive()` to determine when a given platform `AvailabilityDomain` represents the target platform. The compiler's existing mapping from target triple to platform domain is incomplete and it's not clear to me whether fixing that could cause other regressions. Resolves rdar://147413616.
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 20, 2025
swiftlang#79807 caused a regression in which `AvailabilityContext` stopped tracking the available version range for the active platform domain for certain platforms. Fix this by reverting to checking `AvailabilityDomain::isActive()` to determine when a given platform `AvailabilityDomain` represents the target platform. The compiler's existing mapping from target triple to platform domain is incomplete and it's not clear to me whether fixing that could cause other regressions. Resolves rdar://147413616.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables potential unavailability diagnostics to be emitted for decls that are only available in a version-less domain.