Skip to content

utils: Cleanup python installation code in build.ps1. #79387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2025
Merged

utils: Cleanup python installation code in build.ps1. #79387

merged 2 commits into from
Feb 17, 2025

Conversation

jeffdav
Copy link
Contributor

@jeffdav jeffdav commented Feb 14, 2025

This change:

  • Eliminates several PS warnings (unapproved verbs, unused variables)
  • Improves readability and maintainability.
  • Reduces repeated code with Install-PythonWheel helper.
  • Adds types to function parameters.

@jeffdav
Copy link
Contributor Author

jeffdav commented Feb 14, 2025

cc: @compnerd @hjyamauchi

compnerd
compnerd reviewed Feb 14, 2025
View reviewed changes
@jeffdav jeffdav requested a review from compnerd February 14, 2025 18:54
compnerd
compnerd approved these changes Feb 14, 2025
View reviewed changes
@compnerd
Copy link
Member

@swift-ci please smoke test

@compnerd compnerd merged commit d0e4f84 into swiftlang:main Feb 17, 2025
3 checks passed
@jeffdav jeffdav deleted the cleanup-install-python-helpers branch March 17, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdav @compnerd