[CMake] Establish a dependency from standard library variants onto 'libSwiftScan' #77606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
etcwilde
reviewed
Nov 14, 2024
artemcm
force-pushed
the
MoveLibSwiftScanOutOfTools
branch
from
ac7c176 to
691de13
Compare
|
@swift-ci smoke test |
'tools' should be reserved for executable tools.
artemcm
force-pushed
the
MoveLibSwiftScanOutOfTools
branch
from
691de13 to
338b914
Compare
|
@swift-ci smoke test |
This was referenced Nov 14, 2024
Closed
artemcm
added a commit
to swiftlang/swift-driver
that referenced
this pull request
Dec 3, 2024
…ibSwiftScan When building the compiler toolchain, there is currently a race condition which makes it so that the 'libSwiftScan.dylib' is not ready by the time the driver is used to begin compilation of the Swift standard library. For now, disable in-process queries altogether. On 'main', this is resolved with swiftlang/swift#77606, which seems to be a challenge to backport to 6.0.
artemcm
added a commit
to swiftlang/swift-driver
that referenced
this pull request
Dec 9, 2024
…ibSwiftScan When building the compiler toolchain, there is currently a race condition which makes it so that the 'libSwiftScan.dylib' is not ready by the time the driver is used to begin compilation of the Swift standard library. For now, disable in-process queries altogether. On 'main', this is resolved with swiftlang/swift#77606, which seems to be a challenge to backport to 6.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift/CMakeLists.txt
Lines 1475 to 1500 in 1965f96
stdlibbeforetools. To bypass that, begin separating libraries used by the compiler into a separate directory inlib:Tooling, just like Clang does, and ensure they get configured before the standard library build.