Skip to content

[CMake] Add a dependency on 'libSwiftScan' for 'swiftCore' #77541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Nov 11, 2024

It appears that 'swiftCore' and following associated 'embedded-stdlib-*' targets may begin building before the libSwiftScan library has completed building, which may cause crashes if the compiler process building 'swiftCore' attempts to load it.

Resolves rdar://137674862

@artemcm artemcm requested a review from etcwilde November 11, 2024 22:58
@artemcm artemcm requested a review from a team as a code owner November 11, 2024 22:58
@artemcm
Copy link
Contributor Author

artemcm commented Nov 11, 2024

@swift-ci test

@artemcm artemcm enabled auto-merge November 11, 2024 23:14
It appears that 'swiftCore' and following associated 'embedded-stdlib-*' targets may begin building before the libSwiftScan library has completed building, which may cause crashes if the compiler process building 'swiftCore' attempts to load it.

Resolves rdar://137674862
@artemcm artemcm force-pushed the AddSwiftScanDepToEmbeddedStdLib branch from e193a1c to 58709e5 Compare November 12, 2024 18:07
@artemcm
Copy link
Contributor Author

artemcm commented Nov 12, 2024

@swift-ci test

@artemcm artemcm merged commit e96fc88 into swiftlang:main Nov 12, 2024
4 of 5 checks passed
@artemcm artemcm deleted the AddSwiftScanDepToEmbeddedStdLib branch November 13, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant