Revert "Make IsolatedDeinit non-experimental" #77438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
requested review from
eeckstein,
jckarter,
hborla,
slavapestov,
xedin and
DougGregor
as code owners
DougGregor
approved these changes
Nov 7, 2024
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test |
|
|
@swift-ci please smoke test Linux |
ktoso
deleted the
revert-77364-mpokhylets/non-experimental-isolated-deinit
branch
nickolas-pohilets
added a commit
to nickolas-pohilets/swift
that referenced
this pull request
Nov 14, 2024
nickolas-pohilets
added a commit
to nickolas-pohilets/swift
that referenced
this pull request
Nov 20, 2024
nickolas-pohilets
added a commit
to nickolas-pohilets/swift
that referenced
this pull request
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #77364
We have to keep it experimental for now while we keep addressing some issues this still has.
FYI @nickolas-pohilets sadly this work keeps triggering large scale fallout in optimized or simulator CIs we run after merging through the PR validation. We'll have to keep working on fixing those.