Improve support in Swift for program address space N in llvm DataLayout #74817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be aware of address spaces for functions: - For closures, allow round trip via opaque ptr in pgmspace. - Fix for mapping program space functions into protocol witness tables and value witness tables. - Fixed in SIL function lowering, addPointerParameter should only create pointers in address space 1 when the parameter is a function (e.g. working with closures). - Fix coroutine/yield emission. - More program address space fixes. - Fix pointer wrangling between address spaces (or not) in coroutine emission. - Fix pointer parameter wrangling between namespaces in call site emission.
|
Let's first bring up the AVR target support so that the compiler at least accepts it for compilation, I'll write down how to get to that in #74818. Let's revisit this afterwards. |
kubamracek
requested review from
DougGregor,
aschwaighofer,
eeckstein and
kubamracek
|
Hey @rjmccall, @DougGregor, @aschwaighofer, @eeckstein, @carlos4242 has merged some basic AVR groundwork and 16-bit stdlib code fixes, and the contents of this PR is what's next on the list towards being able to produce AVR code. The obvious missing piece in this draft is tests, but ignoring that for a second, would you mind taking a look and advising whether this approach in this draft makes sense, and that this is roughly the direction we're looking for? |
|
I think it's time to close this. We can address it in other PRs. The source branch is always available anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rauhul @phausler @kubamracek
[AVR Harvard Architecture fixes]: Update Swift, at least partially, to be aware of address spaces for functions:
I think the AVR target might struggle to produce code without these fixes in many cases. Simple code is OK on AVR but things like function pointers will probably need this. I'm completely open to any other way of supporting this too.