Skip to content

[6.0] Start building and including lld even in Darwin toolchains #73970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2024
Merged

[6.0] Start building and including lld even in Darwin toolchains #73970

merged 1 commit into from
May 29, 2024

Conversation

al45tair
Copy link
Contributor

@al45tair al45tair commented May 29, 2024 •
edited
Loading

We want lld to land in the toolchain everywhere; this is useful for embedded and also for cross-compilation.

rdar://128925574

@kubamracek @al45tair
Merge pull request swiftlang#70715 from kubamracek/embedded-lld
e9ae7ab 
[embedded] Start building and including lld even in Darwin toolchains
@al45tair al45tair added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.0 labels May 29, 2024
@al45tair al45tair requested a review from a team as a code owner May 29, 2024 08:19
@al45tair al45tair requested review from kubamracek and shahmishal May 29, 2024 08:19
@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair
Copy link
Contributor Author

Explanation: lld was added to the toolchain for the main branch, but this wasn't cherry picked for 6.0. We want it in 6.0 for both embedded and cross-compilation support.
Original PR: #70715
Risk: Low. Adds lld, but doesn't affect anything else.
Reviewed by: @MaxDesiatov @phausler @drexin @rauhul
Resolves: rdar://128925574
Tests: There aren't any tests that check that we've got lld here, yet.

@al45tair al45tair enabled auto-merge May 29, 2024 09:26
@MaxDesiatov
Copy link
Contributor

cc @kateinoigakukun

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@al45tair al45tair merged commit ad1d9ff into swiftlang:release/6.0 May 29, 2024
5 checks passed
@al45tair al45tair mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal shahmishal approved these changes

@kubamracek kubamracek Awaiting requested review from kubamracek

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@al45tair @MaxDesiatov @shahmishal @kubamracek