[6.0] Bring back TaskGroup.next() and ThrowingTaskGroup.next() as public API #73431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c API With the introduction of `next(isolation:)` into the task group types, we removed the public APIs for the no-argument `next()` versions, leaving them only as `@usableFromInline internal` entrypoints for the ABI. Because the `next(isolation:)` versions have a default argument, this was sufficient for providing source compatibility for calls, but not for protocol conformances. Bring these APIs back publicly. Fixes rdar://127499568.
|
@swift-ci please test |
hborla
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: A change to introducing
next(isolation:)entry points into(Throwing)TaskGroupalso removed the API fornext(), relying on a default argument to maintain source compatibility for calls to the API. However, this broke protocol conformances that depend on the exact signature ofnext(), so this pull request brings those APIs back as "disfavored" overloads.Original PR: #73425
Risk: Low. Adds back APIs whose removal caused a source incompatibility.
Radar/issue: rdar://127499568
Reviewed by: @hborla
Testing: New tests.