Bring back TaskGroup.next() and ThrowingTaskGroup.next() as public API
#73425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c API With the introduction of `next(isolation:)` into the task group types, we removed the public APIs for the no-argument `next()` versions, leaving them only as `@usableFromInline internal` entrypoints for the ABI. Because the `next(isolation:)` versions have a default argument, this was sufficient for providing source compatibility for calls, but not for protocol conformances. Bring these APIs back publicly. Fixes rdar://127499568.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
hborla
approved these changes
May 3, 2024
|
@swift-ci please smoke test |
|
Late LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of
next(isolation:)into the task group types, we removed the public APIs for the no-argumentnext()versions, leaving them only as@usableFromInline internalentrypoints for the ABI. Because thenext(isolation:)versions have a default argument, this was sufficient for providing source compatibility for calls, but not for protocol conformances.Bring these APIs back publicly. Fixes rdar://127499568.