Extract common code for building opened existential and element signatures #73363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
pack-expansion-closures-part-2
branch
from
93c0c20 to
46dbe06
Compare
slavapestov
requested review from
ahoppen,
bnbarham,
hamishknight,
rintaro and
tshortli
as code owners
slavapestov
force-pushed
the
pack-expansion-closures-part-2
branch
from
46dbe06 to
9e13db0
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #73348. Re-abstraction thunk emission had a utility for building a generic signature from several captured existential or element environments. Make this generally usable, since we need it for closures that capture element environments too.
I’m structuring these PRs to keep the refactoring separate from new code. The 6.0 cherry pick will not change existing logic, it will just add new code that only runs in the case that used to crash.