[AST] Special handling for existentials with superclass and marker pr… #71855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
slavapestov
approved these changes
Feb 29, 2024
| if (auto superclass = layout.explicitSuperclass) { | ||
| if (auto result = | ||
| lookupConformance(superclass, protocol, /*allowMissing=*/false)) { | ||
| if (protocol->isSpecificProtocol(KnownProtocolKind::Sendable) && |
There was a problem hiding this comment.
Is the true branch reachable? It seems we only call this if !protocol->existentialConformsToSelf() but that would be false for Sendable
There was a problem hiding this comment.
I just moved this code over so I'm not sure.
There was a problem hiding this comment.
I saw this in a couple other places I think, will investigate!
There was a problem hiding this comment.
Okay, we do call this in two places where !protocol->existentialConformsToSelf() and later on in case when it is, so it would be reachable at leave in one spot.
xedin
force-pushed
the
fix-sendable-keypath-conformance-issues
branch
2 times, most recently
from
b7c6055 to
7526af5
Compare
|
@swift-ci please test |
…otocols Even if protocol is not self-conforming it should be okay to produce a conformance based on superclass if protocol bounds of the existential are all marker protocols. Superclass concrete conformance is wrapped into an inherited conformance in such cases to reference the existential.
…lowMarkerProtocols` flag
xedin
force-pushed
the
fix-sendable-keypath-conformance-issues
branch
from
7526af5 to
0ab7e12
Compare
|
@swift-ci please test |
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jun 4, 2024
…ngleTypeForFlatUniqueTypeRef` The original check introduced by swiftlang#71855 is too broad. For concrete metadata we call the runtime demangler so we need to strip off marker protocols when mangling that string and `mangleTypeForReflection` already does that.
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jun 5, 2024
…ngleTypeForFlatUniqueTypeRef` The original check introduced by swiftlang#71855 is too broad. For concrete metadata we call the runtime demangler so we need to strip off marker protocols when mangling that string and `mangleTypeForReflection` already does that.
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jun 5, 2024
…ngleTypeForFlatUniqueTypeRef` The original check introduced by swiftlang#71855 is too broad. For concrete metadata we call the runtime demangler so we need to strip off marker protocols when mangling that string and `mangleTypeForReflection` already does that.
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jun 5, 2024
…ngleTypeForFlatUniqueTypeRef` The original check introduced by swiftlang#71855 is too broad. For concrete metadata we call the runtime demangler so we need to strip off marker protocols when mangling that string and `mangleTypeForReflection` already does that. (cherry picked from commit 5d243bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…otocols
Even if protocol is not self-conforming it should be okay to produce a conformance based on superclass
if protocol bounds of the existential are all marker protocols.
Superclass concrete conformance is wrapped into an inherited conformance in such cases to
reference the existential.